Skip to content
Snippets Groups Projects
Select Git revision
  • move-gl-dropdown
  • improve-table-pagination-spec
  • move-markdown-preview
  • winh-fix-merge-request-spec
  • master default
  • index-namespaces-lower-name
  • winh-single-karma-test
  • 10-3-stable
  • 36782-replace-team-user-role-with-add_role-user-in-specs
  • winh-modal-internal-state
  • tz-ide-file-icons
  • 38869-milestone-select
  • update-autodevops-template
  • jivl-activate-repo-cookie-preferences
  • qa-add-deploy-key
  • docs-move-article-ldap
  • 40780-choose-file
  • 22643-manual-job-page
  • refactor-cluster-show-page-conservative
  • dm-sidekiq-versioning
  • v10.4.0.pre
  • v10.3.0
  • v10.3.0-rc5
  • v10.3.0-rc4
  • v10.3.0-rc3
  • v10.3.0-rc2
  • v10.2.5
  • v10.3.0-rc1
  • v10.0.7
  • v10.1.5
  • v10.2.4
  • v10.2.3
  • v10.2.2
  • v10.2.1
  • v10.3.0.pre
  • v10.2.0
  • v10.2.0-rc4
  • v10.2.0-rc3
  • v10.1.4
  • v10.2.0-rc2
40 results

merge_requests_controller_spec.rb

Forked from GitLab.org / GitLab FOSS
2 commits behind, 4974 commits ahead of the upstream repository.
  • Robert Speicher's avatar
    939e9bdd
    Make the 'issuables list meta-data' shared example less dangerous · 939e9bdd
    Robert Speicher authored
    This shared example would take an object's database ID and create a
    number of objects based on it. If for some reason the ID were a high
    number, like 20, this would create `20 + 21 + 22` objects.
    
    Not only was this dangerous from a performance perspective, it was
    entirely unnecessary, as the behavior it was testing is already
    well-tested in the unit test for the underlying object. For a controller
    test, which is what's including this shared example, all we need to do
    is verify that the assigned object contains the correct `id => object`
    Hash, which is what we now test for.
    939e9bdd
    History
    Make the 'issuables list meta-data' shared example less dangerous
    Robert Speicher authored
    This shared example would take an object's database ID and create a
    number of objects based on it. If for some reason the ID were a high
    number, like 20, this would create `20 + 21 + 22` objects.
    
    Not only was this dangerous from a performance perspective, it was
    entirely unnecessary, as the behavior it was testing is already
    well-tested in the unit test for the underlying object. For a controller
    test, which is what's including this shared example, all we need to do
    is verify that the assigned object contains the correct `id => object`
    Hash, which is what we now test for.
merge_requests_controller_spec.rb 19.69 KiB