Skip to content
Snippets Groups Projects
Select Git revision
  • move-gl-dropdown
  • improve-table-pagination-spec
  • move-markdown-preview
  • winh-fix-merge-request-spec
  • master default
  • index-namespaces-lower-name
  • winh-single-karma-test
  • 10-3-stable
  • 36782-replace-team-user-role-with-add_role-user-in-specs
  • winh-modal-internal-state
  • tz-ide-file-icons
  • 38869-milestone-select
  • update-autodevops-template
  • jivl-activate-repo-cookie-preferences
  • qa-add-deploy-key
  • docs-move-article-ldap
  • 40780-choose-file
  • 22643-manual-job-page
  • refactor-cluster-show-page-conservative
  • dm-sidekiq-versioning
  • v10.4.0.pre
  • v10.3.0
  • v10.3.0-rc5
  • v10.3.0-rc4
  • v10.3.0-rc3
  • v10.3.0-rc2
  • v10.2.5
  • v10.3.0-rc1
  • v10.0.7
  • v10.1.5
  • v10.2.4
  • v10.2.3
  • v10.2.2
  • v10.2.1
  • v10.3.0.pre
  • v10.2.0
  • v10.2.0-rc4
  • v10.2.0-rc3
  • v10.1.4
  • v10.2.0-rc2
40 results

delete_user_service.rb

Forked from GitLab.org / GitLab FOSS
36682 commits behind the upstream repository.
  • Stan Hu's avatar
    cb8a425b
    Fix bug where destroying a namespace would not always destroy projects · cb8a425b
    Stan Hu authored
    There is a race condition in DestroyGroupService now that projects are deleted asynchronously:
    
    1. User attempts to delete group
    2. DestroyGroupService iterates through all projects and schedules a Sidekiq job to delete each Project
    3. DestroyGroupService destroys the Group, leaving all its projects without a namespace
    4. Projects::DestroyService runs later but the can?(current_user,
       :remove_project) is `false` because the user no longer has permission to
       destroy projects with no namespace.
    5. This leaves the project in pending_delete state with no namespace/group.
    
    Projects without a namespace or group also adds another problem: it's not possible to destroy the container
    registry tags, since container_registry_path_with_namespace is the wrong value.
    
    The fix is to destroy the group asynchronously and to run execute directly on Projects::DestroyService.
    
    Closes #17893
    cb8a425b
    History
    Fix bug where destroying a namespace would not always destroy projects
    Stan Hu authored
    There is a race condition in DestroyGroupService now that projects are deleted asynchronously:
    
    1. User attempts to delete group
    2. DestroyGroupService iterates through all projects and schedules a Sidekiq job to delete each Project
    3. DestroyGroupService destroys the Group, leaving all its projects without a namespace
    4. Projects::DestroyService runs later but the can?(current_user,
       :remove_project) is `false` because the user no longer has permission to
       destroy projects with no namespace.
    5. This leaves the project in pending_delete state with no namespace/group.
    
    Projects without a namespace or group also adds another problem: it's not possible to destroy the container
    registry tags, since container_registry_path_with_namespace is the wrong value.
    
    The fix is to destroy the group asynchronously and to run execute directly on Projects::DestroyService.
    
    Closes #17893