Skip to content
Snippets Groups Projects
Select Git revision
  • move-gl-dropdown
  • improve-table-pagination-spec
  • move-markdown-preview
  • winh-fix-merge-request-spec
  • master default
  • index-namespaces-lower-name
  • winh-single-karma-test
  • 10-3-stable
  • 36782-replace-team-user-role-with-add_role-user-in-specs
  • winh-modal-internal-state
  • tz-ide-file-icons
  • 38869-milestone-select
  • update-autodevops-template
  • jivl-activate-repo-cookie-preferences
  • qa-add-deploy-key
  • docs-move-article-ldap
  • 40780-choose-file
  • 22643-manual-job-page
  • refactor-cluster-show-page-conservative
  • dm-sidekiq-versioning
  • v10.4.0.pre
  • v10.3.0
  • v10.3.0-rc5
  • v10.3.0-rc4
  • v10.3.0-rc3
  • v10.3.0-rc2
  • v10.2.5
  • v10.3.0-rc1
  • v10.0.7
  • v10.1.5
  • v10.2.4
  • v10.2.3
  • v10.2.2
  • v10.2.1
  • v10.3.0.pre
  • v10.2.0
  • v10.2.0-rc4
  • v10.2.0-rc3
  • v10.1.4
  • v10.2.0-rc2
40 results

method_call_spec.rb

Forked from GitLab.org / GitLab FOSS
Source project has a limited visibility.
  • Yorick Peterse's avatar
    be3b8784
    Track method call times/counts as a single metric · be3b8784
    Yorick Peterse authored
    Previously we'd create a separate Metric instance for every method call
    that would exceed the method call threshold. This is problematic because
    it doesn't provide us with information to accurately get the _total_
    execution time of a particular method. For example, if the method
    "Foo#bar" was called 4 times with a runtime of ~10 milliseconds we'd end
    up with 4 different Metric instances. If we were to then get the
    average/95th percentile/etc of the timings this would be roughly 10
    milliseconds. However, the _actual_ total time spent in this method
    would be around 40 milliseconds.
    
    To solve this problem we now create a single Metric instance per method.
    This Metric instance contains the _total_ real/CPU time and the call
    count for every instrumented method.
    be3b8784
    History
    Track method call times/counts as a single metric
    Yorick Peterse authored
    Previously we'd create a separate Metric instance for every method call
    that would exceed the method call threshold. This is problematic because
    it doesn't provide us with information to accurately get the _total_
    execution time of a particular method. For example, if the method
    "Foo#bar" was called 4 times with a runtime of ~10 milliseconds we'd end
    up with 4 different Metric instances. If we were to then get the
    average/95th percentile/etc of the timings this would be roughly 10
    milliseconds. However, the _actual_ total time spent in this method
    would be around 40 milliseconds.
    
    To solve this problem we now create a single Metric instance per method.
    This Metric instance contains the _total_ real/CPU time and the call
    count for every instrumented method.