Skip to content
Snippets Groups Projects
Select Git revision
  • move-gl-dropdown
  • improve-table-pagination-spec
  • move-markdown-preview
  • winh-fix-merge-request-spec
  • master default
  • index-namespaces-lower-name
  • winh-single-karma-test
  • 10-3-stable
  • 36782-replace-team-user-role-with-add_role-user-in-specs
  • winh-modal-internal-state
  • tz-ide-file-icons
  • 38869-milestone-select
  • update-autodevops-template
  • jivl-activate-repo-cookie-preferences
  • qa-add-deploy-key
  • docs-move-article-ldap
  • 40780-choose-file
  • 22643-manual-job-page
  • refactor-cluster-show-page-conservative
  • dm-sidekiq-versioning
  • v10.4.0.pre
  • v10.3.0
  • v10.3.0-rc5
  • v10.3.0-rc4
  • v10.3.0-rc3
  • v10.3.0-rc2
  • v10.2.5
  • v10.3.0-rc1
  • v10.0.7
  • v10.1.5
  • v10.2.4
  • v10.2.3
  • v10.2.2
  • v10.2.1
  • v10.3.0.pre
  • v10.2.0
  • v10.2.0-rc4
  • v10.2.0-rc3
  • v10.1.4
  • v10.2.0-rc2
40 results

1381-use-commit-count-for-pagination.yml

Forked from GitLab.org / GitLab FOSS
Source project has a limited visibility.
  • Jordan Ryan Reuter's avatar
    473cab81
    Manually set total_count when paginating commits · 473cab81
    Jordan Ryan Reuter authored and Oswaldo Ferreir's avatar Oswaldo Ferreir committed
    `Kaminari.paginate_array` takes some options, most relevant of which is
    a `total_count` parameter. Using the `commit_count` for `total_count`
    lets us correctly treat the return of `Repository#commits` as a subset
    of all the commits we may wish to list.
    
    Addition of a new `Repository#commit_count_for_ref` method was
    necessarry to allow the user to start from an arbitrary ref.
    
    Ref #1381
    473cab81
    History
    Manually set total_count when paginating commits
    Jordan Ryan Reuter authored and Oswaldo Ferreir's avatar Oswaldo Ferreir committed
    `Kaminari.paginate_array` takes some options, most relevant of which is
    a `total_count` parameter. Using the `commit_count` for `total_count`
    lets us correctly treat the return of `Repository#commits` as a subset
    of all the commits we may wish to list.
    
    Addition of a new `Repository#commit_count_for_ref` method was
    necessarry to allow the user to start from an arbitrary ref.
    
    Ref #1381