Skip to content
Snippets Groups Projects
Select Git revision
  • move-gl-dropdown
  • improve-table-pagination-spec
  • move-markdown-preview
  • winh-fix-merge-request-spec
  • master default
  • index-namespaces-lower-name
  • winh-single-karma-test
  • 10-3-stable
  • 36782-replace-team-user-role-with-add_role-user-in-specs
  • winh-modal-internal-state
  • tz-ide-file-icons
  • 38869-milestone-select
  • update-autodevops-template
  • jivl-activate-repo-cookie-preferences
  • qa-add-deploy-key
  • docs-move-article-ldap
  • 40780-choose-file
  • 22643-manual-job-page
  • refactor-cluster-show-page-conservative
  • dm-sidekiq-versioning
  • v10.4.0.pre
  • v10.3.0
  • v10.3.0-rc5
  • v10.3.0-rc4
  • v10.3.0-rc3
  • v10.3.0-rc2
  • v10.2.5
  • v10.3.0-rc1
  • v10.0.7
  • v10.1.5
  • v10.2.4
  • v10.2.3
  • v10.2.2
  • v10.2.1
  • v10.3.0.pre
  • v10.2.0
  • v10.2.0-rc4
  • v10.2.0-rc3
  • v10.1.4
  • v10.2.0-rc2
40 results

projects.rb

Forked from GitLab.org / GitLab FOSS
Source project has a limited visibility.
  • Felix Gilcher's avatar
    ce6436b9
    Don't crash when removing a user that's not project member · ce6436b9
    Felix Gilcher authored
    The attempt to revoke project access for a user that was not member of the
    project results in a 500 Internal Server error where it actually should
    result in a 200 OK since after the operation, the user is not member of
    the project. This turns the operation into an idempotent call that can
    be repeated with no ill effects.
    
    Updated the spec and changed the code accordingly. However, the result differs
    slightly, as we can't return the users project access level if the user was not
    member. I'm not aware if anybody relies on the result of this call.
    
    Fixes #2832
    ce6436b9
    History
    Don't crash when removing a user that's not project member
    Felix Gilcher authored
    The attempt to revoke project access for a user that was not member of the
    project results in a 500 Internal Server error where it actually should
    result in a 200 OK since after the operation, the user is not member of
    the project. This turns the operation into an idempotent call that can
    be repeated with no ill effects.
    
    Updated the spec and changed the code accordingly. However, the result differs
    slightly, as we can't return the users project access level if the user was not
    member. I'm not aware if anybody relies on the result of this call.
    
    Fixes #2832