Skip to content
Snippets Groups Projects
Select Git revision
  • move-gl-dropdown
  • improve-table-pagination-spec
  • move-markdown-preview
  • winh-fix-merge-request-spec
  • master default
  • index-namespaces-lower-name
  • winh-single-karma-test
  • 10-3-stable
  • 36782-replace-team-user-role-with-add_role-user-in-specs
  • winh-modal-internal-state
  • tz-ide-file-icons
  • 38869-milestone-select
  • update-autodevops-template
  • jivl-activate-repo-cookie-preferences
  • qa-add-deploy-key
  • docs-move-article-ldap
  • 40780-choose-file
  • 22643-manual-job-page
  • refactor-cluster-show-page-conservative
  • dm-sidekiq-versioning
  • v10.4.0.pre
  • v10.3.0
  • v10.3.0-rc5
  • v10.3.0-rc4
  • v10.3.0-rc3
  • v10.3.0-rc2
  • v10.2.5
  • v10.3.0-rc1
  • v10.0.7
  • v10.1.5
  • v10.2.4
  • v10.2.3
  • v10.2.2
  • v10.2.1
  • v10.3.0.pre
  • v10.2.0
  • v10.2.0-rc4
  • v10.2.0-rc3
  • v10.1.4
  • v10.2.0-rc2
40 results

CHANGELOG

Blame
Forked from GitLab.org / GitLab FOSS
Source project has a limited visibility.
  • Robert Speicher's avatar
    b93744e3
    Merge branch 'merge-when-build-succeeds-unchecked' into 'master' · b93744e3
    Robert Speicher authored
    Get "Merge when build succeeds" to work when commits were pushed to MR
    target branch while builds were running
    
    The Merge when build succeeds service only merges when the MR is
    mergeable (open, not WIP, no conflicts).
    
    When the target branch is updated, all affected MRs have their merge
    status set to `unchecked`, and the conflicts check will only happen
    when `check_if_can_be_merged` is called, which happens when the MR page
    is viewed.
    
    When someone enables the automatic merge, the target branch is updated,
    no-one views the MR page again, and the build succeeds, the mergeability
    check will fail and the MR will not in fact be merged.
    
    This MR makes sure `check_if_can_be_merged` is always called when MR
    mergeability is checked.
    
    See merge request !2304
    b93744e3
    History
    Merge branch 'merge-when-build-succeeds-unchecked' into 'master'
    Robert Speicher authored
    Get "Merge when build succeeds" to work when commits were pushed to MR
    target branch while builds were running
    
    The Merge when build succeeds service only merges when the MR is
    mergeable (open, not WIP, no conflicts).
    
    When the target branch is updated, all affected MRs have their merge
    status set to `unchecked`, and the conflicts check will only happen
    when `check_if_can_be_merged` is called, which happens when the MR page
    is viewed.
    
    When someone enables the automatic merge, the target branch is updated,
    no-one views the MR page again, and the build succeeds, the mergeability
    check will fail and the MR will not in fact be merged.
    
    This MR makes sure `check_if_can_be_merged` is always called when MR
    mergeability is checked.
    
    See merge request !2304
To find the state of this project's repository at the time of any of these versions, check out the tags.