Skip to content
Snippets Groups Projects
Select Git revision
  • move-gl-dropdown
  • improve-table-pagination-spec
  • move-markdown-preview
  • winh-fix-merge-request-spec
  • master default
  • index-namespaces-lower-name
  • winh-single-karma-test
  • 10-3-stable
  • 36782-replace-team-user-role-with-add_role-user-in-specs
  • winh-modal-internal-state
  • tz-ide-file-icons
  • 38869-milestone-select
  • update-autodevops-template
  • jivl-activate-repo-cookie-preferences
  • qa-add-deploy-key
  • docs-move-article-ldap
  • 40780-choose-file
  • 22643-manual-job-page
  • refactor-cluster-show-page-conservative
  • dm-sidekiq-versioning
  • v10.4.0.pre
  • v10.3.0
  • v10.3.0-rc5
  • v10.3.0-rc4
  • v10.3.0-rc3
  • v10.3.0-rc2
  • v10.2.5
  • v10.3.0-rc1
  • v10.0.7
  • v10.1.5
  • v10.2.4
  • v10.2.3
  • v10.2.2
  • v10.2.1
  • v10.3.0.pre
  • v10.2.0
  • v10.2.0-rc4
  • v10.2.0-rc3
  • v10.1.4
  • v10.2.0-rc2
40 results

helpers.rb

Blame
  • Forked from GitLab.org / GitLab FOSS
    Source project has a limited visibility.
    • Rémy Coutable's avatar
      0876b460
      Merge branch 'memoize_shell_secret_token' into 'master' · 0876b460
      Rémy Coutable authored
      Memoize Github::Shell's secret token
      
      ## What does this MR do?
      
      `API::Helpers#secret_token` was reading the secret file on every invocation. This MR reads the file in the `gitlab_shell_secret_token.rb` initializer and saves it as a class variable at `Gitlab::Shell.secret_token`
      
      ## Are there points in the code the reviewer needs to double check?
      
       - I'm not sure if the use of `cattr_accessor` is the best approach, or if should be moved into the `class << self` block?
       - Should `API::Helpers#secret_token` be removed in favor of using `Gitlab::Shell.secret_token`?
      
      ## Why was this MR needed?
      
      Performance optimization.
      
      Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/22510
      
      See merge request !6599
      0876b460
      History
      Merge branch 'memoize_shell_secret_token' into 'master'
      Rémy Coutable authored
      Memoize Github::Shell's secret token
      
      ## What does this MR do?
      
      `API::Helpers#secret_token` was reading the secret file on every invocation. This MR reads the file in the `gitlab_shell_secret_token.rb` initializer and saves it as a class variable at `Gitlab::Shell.secret_token`
      
      ## Are there points in the code the reviewer needs to double check?
      
       - I'm not sure if the use of `cattr_accessor` is the best approach, or if should be moved into the `class << self` block?
       - Should `API::Helpers#secret_token` be removed in favor of using `Gitlab::Shell.secret_token`?
      
      ## Why was this MR needed?
      
      Performance optimization.
      
      Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/22510
      
      See merge request !6599