Skip to content
Snippets Groups Projects
Select Git revision
  • move-gl-dropdown
  • improve-table-pagination-spec
  • move-markdown-preview
  • winh-fix-merge-request-spec
  • master default
  • index-namespaces-lower-name
  • winh-single-karma-test
  • 10-3-stable
  • 36782-replace-team-user-role-with-add_role-user-in-specs
  • winh-modal-internal-state
  • tz-ide-file-icons
  • 38869-milestone-select
  • update-autodevops-template
  • jivl-activate-repo-cookie-preferences
  • qa-add-deploy-key
  • docs-move-article-ldap
  • 40780-choose-file
  • 22643-manual-job-page
  • refactor-cluster-show-page-conservative
  • dm-sidekiq-versioning
  • v10.4.0.pre
  • v10.3.0
  • v10.3.0-rc5
  • v10.3.0-rc4
  • v10.3.0-rc3
  • v10.3.0-rc2
  • v10.2.5
  • v10.3.0-rc1
  • v10.0.7
  • v10.1.5
  • v10.2.4
  • v10.2.3
  • v10.2.2
  • v10.2.1
  • v10.3.0.pre
  • v10.2.0
  • v10.2.0-rc4
  • v10.2.0-rc3
  • v10.1.4
  • v10.2.0-rc2
40 results

git_access.rb

Forked from GitLab.org / GitLab FOSS
24268 commits behind the upstream repository.
  • Stan Hu's avatar
    4be77d0b
    Improve multiple branch push performance by memoizing permission checking · 4be77d0b
    Stan Hu authored
    If you attempt to push thousands of branches at once, the 60-second timeout
    will occur because GitAccess checking does a lot of work to check if the
    user has permission to push to a branch. This changes does two things:
    
    1. Instead of making 1 DB query per branch push, use a memoized list of protected branches to check
    2. Memoize what permissions the user has to perform on this project
    
    On a test of 10,000 branch pushes, this prevents gitlab-shell from hitting the 60-second
    timeout.
    
    Closes #17225
    4be77d0b
    History
    Improve multiple branch push performance by memoizing permission checking
    Stan Hu authored
    If you attempt to push thousands of branches at once, the 60-second timeout
    will occur because GitAccess checking does a lot of work to check if the
    user has permission to push to a branch. This changes does two things:
    
    1. Instead of making 1 DB query per branch push, use a memoized list of protected branches to check
    2. Memoize what permissions the user has to perform on this project
    
    On a test of 10,000 branch pushes, this prevents gitlab-shell from hitting the 60-second
    timeout.
    
    Closes #17225
git_access.rb 5.67 KiB