Skip to content
Snippets Groups Projects
Select Git revision
  • move-gl-dropdown
  • improve-table-pagination-spec
  • move-markdown-preview
  • winh-fix-merge-request-spec
  • master default
  • index-namespaces-lower-name
  • winh-single-karma-test
  • 10-3-stable
  • 36782-replace-team-user-role-with-add_role-user-in-specs
  • winh-modal-internal-state
  • tz-ide-file-icons
  • 38869-milestone-select
  • update-autodevops-template
  • jivl-activate-repo-cookie-preferences
  • qa-add-deploy-key
  • docs-move-article-ldap
  • 40780-choose-file
  • 22643-manual-job-page
  • refactor-cluster-show-page-conservative
  • dm-sidekiq-versioning
  • v10.4.0.pre
  • v10.3.0
  • v10.3.0-rc5
  • v10.3.0-rc4
  • v10.3.0-rc3
  • v10.3.0-rc2
  • v10.2.5
  • v10.3.0-rc1
  • v10.0.7
  • v10.1.5
  • v10.2.4
  • v10.2.3
  • v10.2.2
  • v10.2.1
  • v10.3.0.pre
  • v10.2.0
  • v10.2.0-rc4
  • v10.2.0-rc3
  • v10.1.4
  • v10.2.0-rc2
40 results

group_member.rb

Forked from GitLab.org / GitLab FOSS
Source project has a limited visibility.
  • Rémy Coutable's avatar
    ec0061a9
    Allow Member.add_user to handle access requesters · ec0061a9
    Rémy Coutable authored
    
    Changes include:
    
    - Ensure Member.add_user is not called directly when not necessary
    - New GroupMember.add_users_to_group to have the same abstraction level as for Project
    - Refactor Member.add_user to take a source instead of an array of members
    - Fix Rubocop offenses
    - Always use Project#add_user instead of project.team.add_user
    - Factorize users addition as members in Member.add_users_to_source
    - Make access_level a keyword argument in GroupMember.add_users_to_group and ProjectMember.add_users_to_projects
    - Destroy any requester before adding them as a member
    - Improve the way we handle access requesters in Member.add_user
      Instead of removing the requester and creating a new member,
      we now simply accepts their access request. This way, they will
      receive a "access request granted" email.
    - Fix error that was previously silently ignored
    - Stop raising when access level is invalid in Member, let Rails validation do their work
    
    Signed-off-by: default avatarRémy Coutable <remy@rymai.me>
    ec0061a9
    History
    Allow Member.add_user to handle access requesters
    Rémy Coutable authored
    
    Changes include:
    
    - Ensure Member.add_user is not called directly when not necessary
    - New GroupMember.add_users_to_group to have the same abstraction level as for Project
    - Refactor Member.add_user to take a source instead of an array of members
    - Fix Rubocop offenses
    - Always use Project#add_user instead of project.team.add_user
    - Factorize users addition as members in Member.add_users_to_source
    - Make access_level a keyword argument in GroupMember.add_users_to_group and ProjectMember.add_users_to_projects
    - Destroy any requester before adding them as a member
    - Improve the way we handle access requesters in Member.add_user
      Instead of removing the requester and creating a new member,
      we now simply accepts their access request. This way, they will
      receive a "access request granted" email.
    - Fix error that was previously silently ignored
    - Stop raising when access level is invalid in Member, let Rails validation do their work
    
    Signed-off-by: default avatarRémy Coutable <remy@rymai.me>