Skip to content

GitLab

Why GitLab
Pricing
Contact Sales
Explore

Sign in
Get free trial

Primary navigation

Project

GitLab Community Edition
- Activity
- Members
- Labels
- Issues
- Issue boards
- Milestones
- Wiki
- Jira
- Environments
- Incidents

Snippets Groups Projects

Admin message

Do not update/delete: Banner broadcast message test data

Admin message

Do not update/delete: Notification broadcast message test data

0218a0bd

Commit 0218a0bd authored 7 years ago by Grzegorz Bizon

Downloads
- Plain Diff

Merge branch 'dm-update-discussion-diff-position' into 'master'

Update diff discussion position per discussion instead of per note

Closes #33157

See merge request !11833

parents f07aee72 09838ac6

No related branches found

No related tags found

No related merge requests found

Changes 8

Hide whitespace changes

Inline Side-by-side

Showing

app/models/diff_discussion.rb 1 addition, 0 deletions

app/models/diff_discussion.rb
app/models/diff_note.rb 13 additions, 5 deletions

app/models/diff_note.rb
app/models/merge_request.rb 9 additions, 13 deletions

app/models/merge_request.rb
app/services/discussions/update_diff_position_service.rb 41 additions, 0 deletions

app/services/discussions/update_diff_position_service.rb
app/services/notes/diff_position_update_service.rb 0 additions, 33 deletions

app/services/notes/diff_position_update_service.rb
spec/models/diff_note_spec.rb 4 additions, 23 deletions

spec/models/diff_note_spec.rb
spec/models/merge_request_spec.rb 5 additions, 5 deletions

spec/models/merge_request_spec.rb
spec/services/discussions/update_diff_position_service_spec.rb 14 additions, 14 deletions

...services/discussions/update_diff_position_service_spec.rb

with 87 additions and 93 deletions

Loading

0% Loading or .

You are about to add 0 people to the discussion. Proceed with caution.

Finish editing this message first!

Please register or sign in to comment