-
- Downloads
Changed autocomplete_sources into an action that returns a single 'at' type of sources at a time
Finished up autocomplete_sources action and added frontend to fetch data only when its needed Added wait_for_ajax to specs Fixed builds and improved the setup/destroy lifecycle Changed global namespace and DRYed up loading logic Added safety for accidentally loading data twice Removed destroy as its not necessary and is messing with click events from a blur race condition Created AutocompleteSourcesController and updated routes Fixed @undefined from tabbing before load ends Disable tabSelectsMatch until we have loaded data Review changes
Showing
- app/assets/javascripts/gfm_auto_complete.js.es6 112 additions, 121 deletionsapp/assets/javascripts/gfm_auto_complete.js.es6
- app/assets/javascripts/gl_form.js 1 addition, 1 deletionapp/assets/javascripts/gl_form.js
- app/assets/javascripts/issuable_form.js 1 addition, 1 deletionapp/assets/javascripts/issuable_form.js
- app/controllers/projects/autocomplete_sources_controller.rb 48 additions, 0 deletionsapp/controllers/projects/autocomplete_sources_controller.rb
- app/controllers/projects_controller.rb 0 additions, 33 deletionsapp/controllers/projects_controller.rb
- app/views/layouts/_init_auto_complete.html.haml 11 additions, 3 deletionsapp/views/layouts/_init_auto_complete.html.haml
- changelogs/unreleased/18435-autocomplete-is-not-performant.yml 4 additions, 0 deletions...elogs/unreleased/18435-autocomplete-is-not-performant.yml
- config/routes/project.rb 12 additions, 1 deletionconfig/routes/project.rb
- spec/features/participants_autocomplete_spec.rb 4 additions, 3 deletionsspec/features/participants_autocomplete_spec.rb
- spec/features/projects/gfm_autocomplete_load_spec.rb 2 additions, 2 deletionsspec/features/projects/gfm_autocomplete_load_spec.rb
- spec/routing/project_routing_spec.rb 15 additions, 4 deletionsspec/routing/project_routing_spec.rb
Loading
Please register or sign in to comment