-
- Downloads
Only include the user's ID in the time_spent command's update hash
Previously, this would include the entire User record in the update hash, which was rendered in the response using `to_json`, erroneously exposing every attribute of that record, including their (now removed) private token. Now we only include the user ID, and perform the lookup on-demand.
Showing
- app/models/concerns/time_trackable.rb 1 addition, 1 deletionapp/models/concerns/time_trackable.rb
- app/services/quick_actions/interpret_service.rb 2 additions, 2 deletionsapp/services/quick_actions/interpret_service.rb
- lib/api/time_tracking_endpoints.rb 2 additions, 2 deletionslib/api/time_tracking_endpoints.rb
- lib/api/v3/time_tracking_endpoints.rb 2 additions, 2 deletionslib/api/v3/time_tracking_endpoints.rb
- spec/features/milestone_spec.rb 2 additions, 2 deletionsspec/features/milestone_spec.rb
- spec/models/concerns/issuable_spec.rb 2 additions, 2 deletionsspec/models/concerns/issuable_spec.rb
- spec/models/concerns/milestoneish_spec.rb 2 additions, 2 deletionsspec/models/concerns/milestoneish_spec.rb
- spec/services/quick_actions/interpret_service_spec.rb 4 additions, 4 deletionsspec/services/quick_actions/interpret_service_spec.rb
- spec/services/system_note_service_spec.rb 2 additions, 2 deletionsspec/services/system_note_service_spec.rb
- spec/support/api/time_tracking_shared_examples.rb 3 additions, 3 deletionsspec/support/api/time_tracking_shared_examples.rb
- spec/support/api/v3/time_tracking_shared_examples.rb 3 additions, 3 deletionsspec/support/api/v3/time_tracking_shared_examples.rb
Loading
Please register or sign in to comment