Skip to content
Snippets Groups Projects
Commit 4c3ec579 authored by James Lopez's avatar James Lopez
Browse files

added more specs

parent fd5062a8
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -82,6 +82,8 @@ class GroupsController < Groups::ApplicationController
if Groups::UpdateService.new(@group, current_user, group_params).execute
redirect_to edit_group_path(@group), notice: "Group '#{@group.name}' was successfully updated."
else
@group.reload
render action: "edit"
end
end
Loading
Loading
Loading
Loading
@@ -122,8 +122,8 @@ describe GroupsController do
allow_any_instance_of(Group).to receive(:move_dir).and_raise(Gitlab::UpdatePathError)
post :update, id: group.to_param, group: { path: 'new_path' }
 
expect(response).to have_http_status(302)
expect(controller).to set_flash[:alert]
expect(assigns(:group).errors).not_to be_empty
expect(assigns(:group).path).not_to eq('new_path')
end
end
end
Loading
Loading
@@ -59,8 +59,6 @@ describe Groups::UpdateService, services: true do
end
 
it 'returns true' do
puts internal_group.errors.full_messages
expect(service.execute).to eq(true)
end
 
Loading
Loading
@@ -82,6 +80,10 @@ describe Groups::UpdateService, services: true do
 
expect(internal_group.errors.full_messages.first).to eq('Gitlab::UpdatePathError')
end
it "hasn't changed the path" do
expect { service.execute}.not_to change { internal_group.reload.path}
end
end
end
end
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment