-
- Downloads
Merge branch 'fix-diff-patch-public-mr' into 'master'
Fix downloading of patches on public merge requests when user logged out ### What does this MR do? This MR makes it possible to download a diff patch on a public merge request when a user is logged out. ### Why was this MR needed? An Error 500 would result when a user attempted to click on the "Email Patches" or "Plain Diff" button: ``` NoMethodError - undefined method `id' for nil:NilClass: lib/gitlab/backend/shell_env.rb:9:in `set_env' lib/gitlab/satellite/action.rb:20:in `in_locked_and_timed_satellite' lib/gitlab/satellite/merge_action.rb:49:in `diff_in_satellite' app/models/merge_request.rb:219:in `to_diff' app/controllers/projects/merge_requests_controller.rb:42:in `block (2 levels) in show' ``` ### What are the relevant issue numbers? * Closes #1225 * Closes #1854 (dup) * Closes #1858 (dup) See merge request !872
No related branches found
No related tags found
Showing
- CHANGELOG 1 addition, 0 deletionsCHANGELOG
- features/project/merge_requests.feature 12 additions, 0 deletionsfeatures/project/merge_requests.feature
- features/steps/project/merge_requests.rb 22 additions, 0 deletionsfeatures/steps/project/merge_requests.rb
- features/steps/shared/paths.rb 5 additions, 0 deletionsfeatures/steps/shared/paths.rb
- lib/gitlab/backend/shell_env.rb 3 additions, 1 deletionlib/gitlab/backend/shell_env.rb
- lib/gitlab/satellite/action.rb 4 additions, 2 deletionslib/gitlab/satellite/action.rb
Loading
Please register or sign in to comment