Skip to content
Snippets Groups Projects
Commit 57fd233a authored by Zeger-Jan van de Weg's avatar Zeger-Jan van de Weg Committed by Z.J. van de Weg
Browse files

Update docs and unexpose token

parent a4827ee2
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -27,11 +27,14 @@ Example response:
 
```json
[
{
"id" : 1,
"url" : "https://gitlab.example.com/hook",
"created_at" : "2015-11-04T20:07:35.874Z"
}
{
"id":1,
"url":"https://gitlab.example.com/hook",
"created_at":"2016-10-31T12:32:15.192Z",
"push_events":true,
"tag_push_events":false,
"enable_ssl_verification":true
}
]
```
 
Loading
Loading
@@ -48,6 +51,10 @@ POST /hooks
| Attribute | Type | Required | Description |
| --------- | ---- | -------- | ----------- |
| `url` | string | yes | The hook URL |
| token | string | no | The token to validate payloads |
| push_events | boolean | no | When true, the hook will fire on push events |
| tag_push_events | boolean | no | When true, the hook will fire on new tags being pushed |
| enable_ssl_verification | boolean | no | Do SSL verification when triggering the hook |
 
Example request:
 
Loading
Loading
@@ -59,11 +66,14 @@ Example response:
 
```json
[
{
"id" : 2,
"url" : "https://gitlab.example.com/hook",
"created_at" : "2015-11-04T20:07:35.874Z"
}
{
"id":1,
"url":"https://gitlab.example.com/hook",
"created_at":"2016-10-31T12:32:15.192Z",
"push_events":true,
"tag_push_events":false,
"enable_ssl_verification":true
}
]
```
 
Loading
Loading
Loading
Loading
@@ -44,7 +44,7 @@ module API
 
class Hook < Grape::Entity
expose :id, :url, :created_at, :push_events, :tag_push_events
expose :enable_ssl_verification, :token
expose :enable_ssl_verification
end
 
class ProjectHook < Hook
Loading
Loading
Loading
Loading
@@ -12,6 +12,7 @@ module API
end
get do
hooks = SystemHook.all
present hooks, with: Entities::Hook
end
 
Loading
Loading
Loading
Loading
@@ -30,7 +30,6 @@ describe API::API, api: true do
it "returns an array of hooks" do
get api("/hooks", admin)
 
byebug
expect(response).to have_http_status(200)
expect(json_response).to be_an Array
expect(json_response.first['url']).to eq(hook.url)
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment