-
- Downloads
Merge branch 'rs-diff_view' into 'master'
Always read diff_view setting from the cookie Prior, when the user had their view set to "parallel" and then visited a merge request's changes tab _without_ passing the `view` parameter via query string, the view would be parallel but the `Notes` class was always instantiated with the default value from `diff_view` ("inline"), resulting in broken markup when the form to add a line note was dynamically inserted. The cookie is set whenever the view is changed, so this value should always be up-to-date. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/14557 and https://gitlab.com/gitlab-org/gitlab-ce/issues/15285 See merge request !3732
Showing
- app/controllers/projects/application_controller.rb 1 addition, 2 deletionsapp/controllers/projects/application_controller.rb
- app/helpers/diff_helper.rb 7 additions, 1 deletionapp/helpers/diff_helper.rb
- app/views/projects/merge_requests/_show.html.haml 1 addition, 1 deletionapp/views/projects/merge_requests/_show.html.haml
- spec/controllers/projects/merge_requests_controller_spec.rb 0 additions, 8 deletionsspec/controllers/projects/merge_requests_controller_spec.rb
- spec/helpers/diff_helper_spec.rb 20 additions, 0 deletionsspec/helpers/diff_helper_spec.rb
Loading
Please register or sign in to comment