Skip to content

GitLab

Why GitLab
Pricing
Contact Sales
Explore

Sign in
Get free trial

Primary navigation

Project

GitLab Community Edition
- Activity
- Members
- Labels
- Issues
- Issue boards
- Milestones
- Wiki
- Jira
- Environments
- Incidents

Snippets Groups Projects

Admin message

Do not update/delete: Banner broadcast message test data

Admin message

Do not update/delete: Notification broadcast message test data

6eb45df2

Commit 6eb45df2 authored 8 years ago by Clement Ho

Downloads
- Plain Diff

Merge branch '25465-todo-done-clicking-is-kind-of-unsafe' into 'master'

Todo done clicking is kind of unusable.

Closes #25465

See merge request !8691

parents 5f3f6ee6 26160459

No related branches found

No related tags found

No related merge requests found

Changes 12

Hide whitespace changes

Inline Side-by-side

Showing

app/assets/javascripts/todos.js.es6 58 additions, 85 deletions

app/assets/javascripts/todos.js.es6
app/assets/stylesheets/pages/todos.scss 12 additions, 0 deletions

app/assets/stylesheets/pages/todos.scss
app/controllers/dashboard/todos_controller.rb 6 additions, 0 deletions

app/controllers/dashboard/todos_controller.rb
app/services/todo_service.rb 19 additions, 6 deletions

app/services/todo_service.rb
app/views/dashboard/todos/_todo.html.haml 4 additions, 1 deletion

app/views/dashboard/todos/_todo.html.haml
changelogs/unreleased/25465-todo-done-clicking-is-kind-of-unsafe.yml 4 additions, 0 deletions

...unreleased/25465-todo-done-clicking-is-kind-of-unsafe.yml
config/routes/dashboard.rb 3 additions, 0 deletions

config/routes/dashboard.rb
features/steps/dashboard/todos.rb 14 additions, 9 deletions

features/steps/dashboard/todos.rb
spec/controllers/dashboard/todos_controller_spec.rb 20 additions, 5 deletions

spec/controllers/dashboard/todos_controller_spec.rb
spec/factories/todos.rb 4 additions, 0 deletions

spec/factories/todos.rb
spec/features/todos/todos_spec.rb 46 additions, 31 deletions

spec/features/todos/todos_spec.rb
spec/services/todo_service_spec.rb 24 additions, 12 deletions

spec/services/todo_service_spec.rb

with 214 additions and 149 deletions

Loading

0% Loading or .

You are about to add 0 people to the discussion. Proceed with caution.

Finish editing this message first!

Please register or sign in to comment