feature and fix for 500 on group missing

app/controllers/groups_controller.rb

@@ -81,6 +81,7 @@ class GroupsController < Groups::ApplicationController
   def group
     @group ||= Group.find_by(path: params[:id])
+    render_404 unless @group
   end
   def load_projects

features/explore/groups.feature

@@ -3,6 +3,11 @@ Feature: Explore Groups
   Background:
     Given group "TestGroup" has private project "Enterprise"
+  Scenario: I should not see a group if it does not exist
+    When I sign in as a user
+    And I visit group "NonExistentGroup" page
+    Then page status code should be 404
+
   Scenario: I should see group with private and internal projects as user
     Given group "TestGroup" has internal project "Internal"
     When I sign in as a user

features/steps/explore/groups.rb

@@ -26,6 +26,10 @@ class Spinach::Features::ExploreGroups < Spinach::FeatureSteps
     visit group_path(Group.find_by(name: "TestGroup"))
   end
+  step 'I visit group "NonExistentGroup" page' do
+    visit group_path(-1)
+  end
+
   step 'I visit group "TestGroup" issues page' do
     visit issues_group_path(Group.find_by(name: "TestGroup"))
   end