-
- Downloads
Merge branch '18583-implement-access-request-to-project-group-api' into 'master'
Add group members API endpoints to request access and approve requests ## What does this MR do? Add group members API endpoints to request access and approve requests. ## Are there points in the code the reviewer needs to double check? I chose to factorize the group/project members API as well as the new group/project access requests API. I initially also created new services to centralize the permission checks related to actions on members, but this was out of scope and this MR is already quite big so I opened a temp MR at !5566 based on this one. ## Why was this MR needed? To finish the "request access" feature. ## What are the relevant issue numbers? Closes #18583. ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [x] API support added - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !4833
No related branches found
No related tags found
Showing
- CHANGELOG 1 addition, 0 deletionsCHANGELOG
- app/models/members/project_member.rb 1 addition, 0 deletionsapp/models/members/project_member.rb
- app/models/project.rb 4 additions, 0 deletionsapp/models/project.rb
- app/services/members/destroy_service.rb 3 additions, 2 deletionsapp/services/members/destroy_service.rb
- doc/api/README.md 5 additions, 1 deletiondoc/api/README.md
- doc/api/access_requests.md 147 additions, 0 deletionsdoc/api/access_requests.md
- doc/api/groups.md 1 addition, 81 deletionsdoc/api/groups.md
- doc/api/members.md 182 additions, 0 deletionsdoc/api/members.md
- doc/api/projects.md 2 additions, 88 deletionsdoc/api/projects.md
- lib/api/access_requests.rb 90 additions, 0 deletionslib/api/access_requests.rb
- lib/api/api.rb 6 additions, 2 deletionslib/api/api.rb
- lib/api/entities.rb 13 additions, 11 deletionslib/api/entities.rb
- lib/api/group_members.rb 0 additions, 87 deletionslib/api/group_members.rb
- lib/api/helpers.rb 5 additions, 19 deletionslib/api/helpers.rb
- lib/api/helpers/members_helpers.rb 13 additions, 0 deletionslib/api/helpers/members_helpers.rb
- lib/api/members.rb 155 additions, 0 deletionslib/api/members.rb
- lib/api/project_members.rb 0 additions, 110 deletionslib/api/project_members.rb
- spec/models/member_spec.rb 1 addition, 1 deletionspec/models/member_spec.rb
- spec/models/members/project_member_spec.rb 2 additions, 1 deletionspec/models/members/project_member_spec.rb
- spec/requests/api/access_requests_spec.rb 246 additions, 0 deletionsspec/requests/api/access_requests_spec.rb
Loading
Please register or sign in to comment