-
- Downloads
Merge branch 'feature/svg-badge-template' into 'master'
Use badge image template instead of using separate images ## What does this MR do? Makes it possible to use template for badge instead of having multiple files. ## Are there points in the code the reviewer needs to double check? We also have a deprecated badge in `controllers/ci/projects_controller.rb`. We decided to leave it until 9.0, so we still have images in `public/ci/` until 9.0. ## Why was this MR needed? We are going to implement build coverage badge, and we do not want to store 101 SVG images for each percentage value. ## What are the relevant issue numbers? #3714 ## Screenshots (if relevant)  ## Does this MR meet the acceptance criteria? - [ ] ~~[CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added~~ (refactoring) - [ ] ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~ - [ ] ~~API support added~~ - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [ ] ~~[Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)~~ (refactoring) See merge request !5520
No related branches found
No related tags found
Showing
- app/controllers/projects/badges_controller.rb 2 additions, 1 deletionapp/controllers/projects/badges_controller.rb
- app/controllers/projects/pipelines_settings_controller.rb 1 addition, 1 deletionapp/controllers/projects/pipelines_settings_controller.rb
- app/views/projects/badges/badge.svg.erb 36 additions, 0 deletionsapp/views/projects/badges/badge.svg.erb
- features/steps/project/badges/build.rb 1 addition, 1 deletionfeatures/steps/project/badges/build.rb
- lib/gitlab/badge/build.rb 12 additions, 28 deletionslib/gitlab/badge/build.rb
- lib/gitlab/badge/build/metadata.rb 36 additions, 0 deletionslib/gitlab/badge/build/metadata.rb
- lib/gitlab/badge/build/template.rb 63 additions, 0 deletionslib/gitlab/badge/build/template.rb
- spec/lib/gitlab/badge/build/metadata_spec.rb 37 additions, 0 deletionsspec/lib/gitlab/badge/build/metadata_spec.rb
- spec/lib/gitlab/badge/build/template_spec.rb 76 additions, 0 deletionsspec/lib/gitlab/badge/build/template_spec.rb
- spec/lib/gitlab/badge/build_spec.rb 51 additions, 69 deletionsspec/lib/gitlab/badge/build_spec.rb
Loading
Please register or sign in to comment