Skip to content

GitLab

Why GitLab
Pricing
Contact Sales
Explore

Sign in
Get free trial

Primary navigation

Project

GitLab Community Edition
- Activity
- Members
- Labels
- Issues
- Issue boards
- Milestones
- Wiki
- Jira
- Environments
- Incidents

Snippets Groups Projects

Admin message

Do not update/delete: Banner broadcast message test data

Admin message

Do not update/delete: Notification broadcast message test data

aeb2869f

Commit aeb2869f authored 7 years ago by Nick Thomas

Downloads
- Patches
- Plain Diff

Prevent bad data being added to application settings when Redis is unavailable

parent cd735170

No related branches found

No related tags found

Loading

Changes 5

Hide whitespace changes

Inline Side-by-side

Showing

app/models/application_setting.rb 3 additions, 0 deletions

app/models/application_setting.rb
changelogs/unreleased/34728-fix-application-setting-created-when-redis-down.yml 4 additions, 0 deletions

...34728-fix-application-setting-created-when-redis-down.yml
lib/gitlab/current_settings.rb 1 addition, 6 deletions

lib/gitlab/current_settings.rb
spec/lib/gitlab/current_settings_spec.rb 15 additions, 2 deletions

spec/lib/gitlab/current_settings_spec.rb
spec/models/application_setting_spec.rb 12 additions, 0 deletions

spec/models/application_setting_spec.rb

with 35 additions and 8 deletions

Loading

0% Loading or .

You are about to add 0 people to the discussion. Proceed with caution.

Finish editing this message first!

Please register or sign in to comment