-
- Downloads
Optimize system note visibility checking by hiding notes that
have been fully redacted and contain cross-project references. The previous implementation relied on Note#cross_reference_not_visible_for?, which essentially tries to render all the Markdown references in a system note and only displays the note if the user can see the referring project. But this duplicated the work that Banzai::NotesRenderer was doing already. Instead, for each note we render, we memoize the number of visible user references and use it later if it is available. Improves #19273
Showing
- CHANGELOG 1 addition, 0 deletionsCHANGELOG
- app/models/note.rb 13 additions, 1 deletionapp/models/note.rb
- lib/banzai/object_renderer.rb 4 additions, 6 deletionslib/banzai/object_renderer.rb
- lib/banzai/redactor.rb 25 additions, 12 deletionslib/banzai/redactor.rb
- spec/features/notes_on_merge_requests_spec.rb 22 additions, 0 deletionsspec/features/notes_on_merge_requests_spec.rb
- spec/lib/banzai/object_renderer_spec.rb 6 additions, 2 deletionsspec/lib/banzai/object_renderer_spec.rb
- spec/lib/banzai/redactor_spec.rb 22 additions, 2 deletionsspec/lib/banzai/redactor_spec.rb
- spec/models/note_spec.rb 14 additions, 0 deletionsspec/models/note_spec.rb
Loading
Please register or sign in to comment