-
- Downloads
Improve handling of large diffs
Diffs with a large number of changed lines time out (504 HTTP error) or generate a HTML page that's so heavy web browsers struggle with it. https://github.com/gitlabhq/gitlabhq/pull/5014 introduced limits on commit line count so that only a safe portion is rendered. This was later undone by code refactoring in be5b6db8, e0eb4803 and c741fcab. This patch re-introduces a safe limit on number of lines.
Showing
- CHANGELOG 1 addition, 0 deletionsCHANGELOG
- app/helpers/diff_helper.rb 14 additions, 5 deletionsapp/helpers/diff_helper.rb
- app/views/projects/diffs/_diffs.html.haml 5 additions, 3 deletionsapp/views/projects/diffs/_diffs.html.haml
- app/views/projects/diffs/_warning.html.haml 1 addition, 1 deletionapp/views/projects/diffs/_warning.html.haml
- spec/helpers/diff_helper_spec.rb 53 additions, 1 deletionspec/helpers/diff_helper_spec.rb
Loading
Please register or sign in to comment