Skip to content
Snippets Groups Projects
Commit b3a1961a authored by Grzegorz Bizon's avatar Grzegorz Bizon
Browse files

Do not expose internal artifacts hash in build entity

parent 6f5a68f5
No related branches found
No related tags found
No related merge requests found
class BuildDetailsEntity < BuildEntity class BuildDetailsEntity < BuildEntity
expose :coverage, :erased_at, :duration expose :coverage, :erased_at, :duration
expose :tag_list, as: :tags expose :tag_list, as: :tags
expose :user, using: UserEntity expose :user, using: UserEntity
expose :runner, using: RunnerEntity
expose :pipeline, using: PipelineEntity
   
expose :erased_by, if: -> (*) { build.erased? }, using: UserEntity expose :erased_by, if: -> (*) { build.erased? }, using: UserEntity
expose :erase_path, if: -> (*) { build.erasable? && can?(current_user, :update_build, project) } do |build| expose :erase_path, if: -> (*) { build.erasable? && can?(current_user, :update_build, project) } do |build|
erase_namespace_project_job_path(project.namespace, project, build) erase_namespace_project_job_path(project.namespace, project, build)
end end
   
expose :artifacts, using: BuildArtifactEntity
expose :runner, using: RunnerEntity
expose :pipeline, using: PipelineEntity
expose :merge_request, if: -> (*) { can?(current_user, :read_merge_request, build.merge_request) } do expose :merge_request, if: -> (*) { can?(current_user, :read_merge_request, build.merge_request) } do
expose :iid do |build| expose :iid do |build|
build.merge_request.iid build.merge_request.iid
Loading
Loading
Loading
@@ -29,7 +29,7 @@ describe BuildDetailsEntity do
Loading
@@ -29,7 +29,7 @@ describe BuildDetailsEntity do
   
it 'contains the needed key value pairs' do it 'contains the needed key value pairs' do
expect(subject).to include(:coverage, :erased_at, :duration) expect(subject).to include(:coverage, :erased_at, :duration)
expect(subject).to include(:artifacts, :runner, :pipeline) expect(subject).to include(:runner, :pipeline)
expect(subject).to include(:raw_path, :merge_request) expect(subject).to include(:raw_path, :merge_request)
expect(subject).to include(:new_issue_path) expect(subject).to include(:new_issue_path)
end end
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment