Skip to content
Snippets Groups Projects
Commit bdc13c31 authored by Grzegorz Bizon's avatar Grzegorz Bizon
Browse files

Untangle status label and text in ci status helper

parent c8b2aa8d
No related branches found
No related tags found
No related merge requests found
Loading
@@ -5,8 +5,8 @@ module CiStatusHelper
Loading
@@ -5,8 +5,8 @@ module CiStatusHelper
end end
   
def ci_status_with_icon(status, target = nil) def ci_status_with_icon(status, target = nil)
content = ci_icon_for_status(status) + ci_label_for_status(status) content = ci_icon_for_status(status) + ci_text_for_status(status)
klass = "ci-status ci-#{status}" # TODO, add support for detailed status klass = "ci-status ci-#{status}"
   
if target if target
link_to content, target, class: klass link_to content, target, class: klass
Loading
@@ -15,6 +15,14 @@ module CiStatusHelper
Loading
@@ -15,6 +15,14 @@ module CiStatusHelper
end end
end end
   
def ci_text_for_status(status)
if detailed_status?(status)
status.text
else
status
end
end
def ci_label_for_status(status) def ci_label_for_status(status)
if detailed_status?(status) if detailed_status?(status)
return status.label return status.label
Loading
Loading
Loading
@@ -22,6 +22,17 @@ module Gitlab
Loading
@@ -22,6 +22,17 @@ module Gitlab
"#{@subject.class.name.demodulize}: #{label}" "#{@subject.class.name.demodulize}: #{label}"
end end
   
# Deprecation warning: this method is here because we need to maintain
# backwards compatibility with legacy statuses. We often do something
# like "ci-status ci-status-#{status}" to set CSS class.
#
# `to_s` method should be renamed to `group` at some point, after
# phasing legacy satuses out.
#
def to_s
self.class.name.demodulize.downcase
end
def has_details? def has_details?
raise NotImplementedError raise NotImplementedError
end end
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment