-
- Downloads
Merge branch 'test-improve-gitlab-identifier' into 'master'
Refactor Gitlab::Identifier ## What does this MR do? This refactors `Gitlab::Identifier` so that it: 1. Has tests 2. Caches output in an instance variable to reduce queries 3. Uses only a single query to find a user by an SSH key, instead of 2 ## Why was this MR needed? This code was untested and would execute more SQL queries than needed. See merge request !6680
No related branches found
No related tags found
Showing
- CHANGELOG 1 addition, 0 deletionsCHANGELOG
- app/models/user.rb 5 additions, 0 deletionsapp/models/user.rb
- lib/gitlab/identifier.rb 50 additions, 8 deletionslib/gitlab/identifier.rb
- spec/lib/gitlab/identifier_spec.rb 123 additions, 0 deletionsspec/lib/gitlab/identifier_spec.rb
- spec/models/user_spec.rb 17 additions, 0 deletionsspec/models/user_spec.rb
- spec/workers/post_receive_spec.rb 3 additions, 1 deletionspec/workers/post_receive_spec.rb
Loading
Please register or sign in to comment