-
- Downloads
Optimize maximum user access level lookup in loading of notes
NotesHelper#note_editable? and ProjectTeam#human_max_access currently take about 16% of the load time of an issue page. This MR preloads the maximum access level of users for all notes in issues and merge requests with several queries instead of one per user and caches the result in RequestStore.
Showing
- CHANGELOG 1 addition, 0 deletionsCHANGELOG
- app/controllers/projects/issues_controller.rb 3 additions, 0 deletionsapp/controllers/projects/issues_controller.rb
- app/controllers/projects/merge_requests_controller.rb 3 additions, 0 deletionsapp/controllers/projects/merge_requests_controller.rb
- app/helpers/notes_helper.rb 7 additions, 8 deletionsapp/helpers/notes_helper.rb
- app/models/ability.rb 14 additions, 0 deletionsapp/models/ability.rb
- app/models/project_team.rb 35 additions, 11 deletionsapp/models/project_team.rb
- lib/gitlab/access.rb 1 addition, 0 deletionslib/gitlab/access.rb
- spec/helpers/notes_helper_spec.rb 31 additions, 26 deletionsspec/helpers/notes_helper_spec.rb
- spec/models/ability_spec.rb 56 additions, 0 deletionsspec/models/ability_spec.rb
- spec/models/project_team_spec.rb 43 additions, 8 deletionsspec/models/project_team_spec.rb
Loading
Please register or sign in to comment