-
- Downloads
Merge branch 'fix-sidebar' into 'master'
Fix broken left sidebar navigation Sidebar navigation is broken and it's introduced in !6627. Sidebar pin and hamburger icons were `a` tag before with `#` link on them. That was the main reason why page jumps to top. !6627 was trying to prevent default action but it interferes with the navigation links. I don't want to tweak event listeners for sidebar, instead I just replaced `a` elements with `div` because I think there is no point to have them as `a`. /cc @dzaporozhets @jschatz1 PS: This MR basically reverts !6627. I don't want to add another revert commit instead I reverted it in my editor and committed. See merge request !6648
Showing
- app/assets/javascripts/sidebar.js.es6 5 additions, 7 deletionsapp/assets/javascripts/sidebar.js.es6
- app/assets/stylesheets/framework/sidebar.scss 1 addition, 0 deletionsapp/assets/stylesheets/framework/sidebar.scss
- app/views/layouts/_page.html.haml 3 additions, 2 deletionsapp/views/layouts/_page.html.haml
Loading
Please register or sign in to comment