Skip to content
Snippets Groups Projects
Commit df97e21c authored by George Andrinopoulos's avatar George Andrinopoulos Committed by Rémy Coutable
Browse files

Rebase to master for avoiding failing tests

parent f106ad51
No related branches found
No related tags found
No related merge requests found
---
title: Add all available statuses to scope filter for project builds endpoint
merge_request:
author: George Andrinopoulos
Loading
Loading
@@ -11,7 +11,7 @@ module API
helpers do
params :optional_scope do
optional :scope, types: [String, Array[String]], desc: 'The scope of builds to show',
values: ['pending', 'running', 'failed', 'success', 'canceled'],
values: ::CommitStatus::AVAILABLE_STATUSES,
coerce_with: ->(scope) {
if scope.is_a?(String)
[scope]
Loading
Loading
Loading
Loading
@@ -16,6 +16,8 @@ describe API::Builds, api: true do
let(:query) { '' }
 
before do
create(:ci_build, :skipped, pipeline: pipeline)
get api("/projects/#{project.id}/builds?#{query}", api_user)
end
 
Loading
Loading
@@ -49,6 +51,18 @@ describe API::Builds, api: true do
end
end
 
context 'filter project with scope skipped' do
let(:query) { 'scope=skipped' }
let(:json_build) { json_response.first }
it 'return builds with status skipped' do
expect(response).to have_http_status 200
expect(json_response).to be_an Array
expect(json_response.length).to eq 1
expect(json_build['status']).to eq 'skipped'
end
end
context 'filter project with array of scope elements' do
let(:query) { 'scope[0]=pending&scope[1]=running' }
 
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment