Skip to content

GitLab

Why GitLab
Pricing
Contact Sales
Explore

Sign in
Get free trial

Primary navigation

Project

GitLab Community Edition
- Activity
- Members
- Labels
- Issues
- Issue boards
- Milestones
- Wiki
- Jira
- Environments
- Incidents

Snippets Groups Projects

Admin message

Do not update/delete: Banner broadcast message test data

Admin message

Do not update/delete: Notification broadcast message test data

ef24c625

Commit ef24c625 authored 8 years ago by Robert Speicher

Downloads
- Plain Diff

Merge branch 'rc-improve-members-destroy-service' into 'master'

Improve `Members::DestroyService`

Part of #21979.

See merge request !6267

parents 02dd690a 1592d57c

No related branches found

No related tags found

No related merge requests found

Changes 11

Hide whitespace changes

Inline Side-by-side

Showing

app/controllers/concerns/membership_actions.rb 6 additions, 7 deletions

app/controllers/concerns/membership_actions.rb
app/controllers/groups/group_members_controller.rb 1 addition, 4 deletions

app/controllers/groups/group_members_controller.rb
app/controllers/projects/project_members_controller.rb 2 additions, 4 deletions

app/controllers/projects/project_members_controller.rb
app/services/members/authorized_destroy_service.rb 2 additions, 0 deletions

app/services/members/authorized_destroy_service.rb
app/services/members/destroy_service.rb 32 additions, 7 deletions

app/services/members/destroy_service.rb
lib/api/access_requests.rb 2 additions, 3 deletions

lib/api/access_requests.rb
lib/api/members.rb 1 addition, 1 deletion

lib/api/members.rb
spec/controllers/groups/group_members_controller_spec.rb 2 additions, 2 deletions

spec/controllers/groups/group_members_controller_spec.rb
spec/controllers/projects/project_members_controller_spec.rb 2 additions, 2 deletions

spec/controllers/projects/project_members_controller_spec.rb
spec/requests/api/access_requests_spec.rb 12 additions, 2 deletions

spec/requests/api/access_requests_spec.rb
spec/services/members/destroy_service_spec.rb 78 additions, 37 deletions

spec/services/members/destroy_service_spec.rb

with 140 additions and 69 deletions

Loading

0% Loading or .

You are about to add 0 people to the discussion. Proceed with caution.

Finish editing this message first!

Please register or sign in to comment