-
- Downloads
View-related (and other minor) changes to !5951 based on @rymai's review.
- The `scopes_form` partial can be used in the `admin/applications` view as well - Don't allow partials to access instance variables directly. Instead, pass in the instance variables as local variables, and use `local_assigns.fetch` to assert that the variables are passed in as expected. - Change a few instances of `render :partial` to `render` - Remove an instance of `required: false` in a view, since this is the default - Inline many instances of a local variable (`ip = 'ip'`) in `auth_spec`
Showing
- app/views/admin/applications/_form.html.haml 1 addition, 5 deletionsapp/views/admin/applications/_form.html.haml
- app/views/admin/applications/show.html.haml 1 addition, 1 deletionapp/views/admin/applications/show.html.haml
- app/views/doorkeeper/applications/_form.html.haml 1 addition, 1 deletionapp/views/doorkeeper/applications/_form.html.haml
- app/views/doorkeeper/applications/show.html.haml 1 addition, 1 deletionapp/views/doorkeeper/applications/show.html.haml
- app/views/profiles/personal_access_tokens/_form.html.haml 7 additions, 4 deletionsapp/views/profiles/personal_access_tokens/_form.html.haml
- app/views/profiles/personal_access_tokens/index.html.haml 1 addition, 1 deletionapp/views/profiles/personal_access_tokens/index.html.haml
- app/views/shared/tokens/_scopes_form.html.haml 5 additions, 1 deletionapp/views/shared/tokens/_scopes_form.html.haml
- app/views/shared/tokens/_scopes_list.html.haml 13 additions, 10 deletionsapp/views/shared/tokens/_scopes_list.html.haml
- spec/lib/gitlab/auth_spec.rb 18 additions, 28 deletionsspec/lib/gitlab/auth_spec.rb
Loading
Please register or sign in to comment