Commits · ba962aa3f05bf325e0c435dfba5e9d939ab62085 · jt-gitlab / GitLab Community Edition · GitLab

Snippets Groups Projects

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

Jul 20, 2016
- Cleanup the use of let, feedback: · ba962aa3
  Lin Jen-Shin authored 8 years ago
  ba962aa3
- Lose unneeded instance variables and variables, feedback: · 01dcb5c2
  Lin Jen-Shin authored 8 years ago
  01dcb5c2
- It's not longer than 80 chars · caf6438a
  Lin Jen-Shin authored 8 years ago
  
  caf6438a
- Make sure there's a build · 08f01dbb
  Lin Jen-Shin authored 8 years ago
  
  08f01dbb
- Use the same logic, it should specify that it's not logged in · eea2fd80
  Lin Jen-Shin authored 8 years ago
  
  eea2fd80
- Use 'when logging as guest' for context, feedback: · a77a58df
  Lin Jen-Shin authored 8 years ago
  a77a58df
- Cleanup that a bit · e8bab842
  Lin Jen-Shin authored 8 years ago
  
  e8bab842
- Rename user2 to reporter_user · 782b384f
  Lin Jen-Shin authored 8 years ago
  
  782b384f
- Should check against `authorize_read_builds!` · ff3776c8
  Lin Jen-Shin authored 8 years ago
  
  ff3776c8
- Reuse those two methods · 88aacaa7
  Lin Jen-Shin authored 8 years ago
  
  88aacaa7
- Also exclude artifacts_file with empty string, feedback: · a7713232
  Lin Jen-Shin authored 8 years ago
  a7713232
- Still give descriptions, feedback: · fea934b5
  Lin Jen-Shin authored 8 years ago
  fea934b5
- Use one query. Feedback: · 4a1edae3
  Lin Jen-Shin authored 8 years ago
  4a1edae3
- It should be plural · fcdfeba9
  Lin Jen-Shin authored 8 years ago
  
  fcdfeba9
- Avoid mixing builds from different pipelines: · 9f70abf1
  Lin Jen-Shin authored 8 years ago
  9f70abf1
- Cleanup let a bit, feedback: · a9f3f3c8
  Lin Jen-Shin authored 8 years ago
  a9f3f3c8
- Use only one before, feedback: · 145da6b1
  Lin Jen-Shin authored 8 years ago
  145da6b1
- Past tense: · 0c202f37
  Lin Jen-Shin authored 8 years ago
  0c202f37
- Past tense, feedback: · bdb900cd
  Lin Jen-Shin authored 8 years ago
  bdb900cd
- Join on association · a563f331
  Lin Jen-Shin authored 8 years ago
  
  a563f331
- More complex data manipulating tests to model, and · 66c8c3d4
  Lin Jen-Shin authored 8 years ago
  66c8c3d4
- We need INNER JOIN to get the right pipeline, · 2fe8ebc1
  Lin Jen-Shin authored 8 years ago
  2fe8ebc1
- Use shared_examples, feedback: · 3925436a
  Lin Jen-Shin authored 8 years ago
  3925436a
- Use shared_example rather than methods, feedback: · cf78c357
  Lin Jen-Shin authored 8 years ago
  cf78c357
- That means different things but it's ok here. · 709e805d
  Lin Jen-Shin authored 8 years ago
  709e805d
- Create the pipelines/builds in mixed order, feedback: · b0f7384f
  Lin Jen-Shin authored 8 years ago
  b0f7384f
Jul 19, 2016
- It's no longer needed · 02f58dbd
  Lin Jen-Shin authored 8 years ago
  
  02f58dbd
- Merge remote-tracking branch... · 9ab5ff53
  Lin Jen-Shin authored 8 years ago
  9ab5ff53
- Make minimal changes to specs · 719b0f11
  Kamil Trzcinski authored 8 years ago
  
  719b0f11
- Move Project#latest_successful_builds_for to project_spec.rb · cfd7c445
  Lin Jen-Shin authored 8 years ago
  cfd7c445
- Just use default_branch, feedback: · dc6afd57
  Lin Jen-Shin authored 8 years ago
  dc6afd57
- Now we could use normal relation, feedback: · 09114211
  Lin Jen-Shin authored 8 years ago
  09114211
- Use default_branch rather than master, feedback: · 04658761
  Lin Jen-Shin authored 8 years ago
  04658761
- path_from_ref -> path_for_ref, feedback: · ae83ac99
  Lin Jen-Shin authored 8 years ago
  ae83ac99
- Drop description for simple case, feedback: · 6da27aa6
  Lin Jen-Shin authored 8 years ago
  6da27aa6
- when unauthorized, feedback: · 361f3d06
  Lin Jen-Shin authored 8 years ago
  361f3d06
- Check against type explicit, feedback: · 43b6a3ea
  Lin Jen-Shin authored 8 years ago
  43b6a3ea
- Use for, feedback: · 42656104
  Lin Jen-Shin authored 8 years ago
  42656104
- Use let! feedback: · c3c0406a
  Lin Jen-Shin authored 8 years ago
  c3c0406a
- Remove descriptions for simple case, feedback: · cd449a73
  Lin Jen-Shin authored 8 years ago
  cd449a73