Skip to content

events:use property, primordials

Rodrigo Muino Tomonari requested to merge github/fork/benjamingr/event-target-string-tag-symbol into master

Per Web IDL, EventTarget.prototype[Symbol.toStringTag] should be a data property, not a getter. Commit https://github.com/nodejs/node/commit/56e44601d285483ffe3c6efa3b80743900d84856 introduced it as a getter.

This commit uses SymbolToStringTag from primordials and sets it as a property and not a getter.

Thank you Domenic for pointing this out!

Fixes: #33773 (closed) cc @jasnell

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports