Skip to content

Simplify width for dropdown-menu on mobile

What does this MR do?

This fixes a bug that dropdown-menu-nav is broken on admin's secondary nav, applying these things:

Are there points in the code the reviewer needs to double check?

Yes, check if min-width: 180px is right.

Yes, check if min-width: 150px is right.

text-overflow doesn't look good enough.

Why was this MR needed?

The regression of !12388 (merged) breaks admin's secondary nav on mobile.

Screenshots (updated)

Target: Admin Settings Dropdown

before after
admin-settings-navi-before admin-settings-navi-after

Regression Tests

Regression Test 1: Global Nav Dropdown

before after
global-navi-before global-navi-after

Regression Test 2:

before after
header-new-navi-before header-new-navi-after

Other screenshots for regression tests are on https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12528#note_34624310 and https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12528#note_34639432.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #34468 (closed), #35226 (closed)

cf. #34139 (closed)

Edited by username-removed-100770

Merge request reports

Loading