Fix broken Spinach tests caused by changes in !6550

!6550 (merged) added dropdowns for the branch "from" and "to" fields, but these Spinach tests were not updated accordingly.

Partial fix to #23378 (closed)

@lbennett This is a partial fix to https://gitlab.com/gitlab-org/gitlab-ce/builds/5132637, but as you can see in this build, the spec fails because we can no longer specify commit IDs in the "from" and "to" fields:

 Scenario: I compare refs
    ✔  Given I sign in as a user                    # features/steps/shared/authentication.rb:7
    ✔  And I own a project                          # features/steps/shared/project.rb:5
    ✔  And I visit my project's commits page        # features/steps/shared/paths.rb:239
    ✔  Given I visit compare refs page              # features/steps/shared/paths.rb:314
    HTML screenshot: /Users/stanhu/gitlab/gdk/gitlab/tmp/capybara/screenshot_2016-10-14-16-46-04.710.html
    Image screenshot: /Users/stanhu/gitlab/gdk/gitlab/tmp/capybara/screenshot_2016-10-14-16-46-04.710.png
    !  And I fill compare fields with refs          # features/steps/project/commits/commits.rb:51
    ~  Then I see compared refs                     
    ~  And I unfold diff                            
    ~  Then I should see additional file lines      

        Unable to find link "6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9"
        /Users/stanhu/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/capybara-2.6.2/lib/capybara/node/finders.rb:43:in `block in find`

Mentioned in issue #23378 (closed)

@stanhu Ohh, I can take a look at this spec. :) Thanks for notifying me!

Reassigned to @lbennett

Mentioned in issue #23390 (closed)

Added 1 commit:

• cb749fa1 - Added logic to handle a revision input that does not exist in the menu

Compare with previous version

@stanhu All the tests relating to the compare page should now be fixed. :) Ill take a look at the other failing specs.

Reassigned to @stanhu

@lbennett Thanks for working on this. I tried the compare page, but it's still not accepting refs.

@stanhu The UX is a little different, we ' load all refs to commits, soI figured we needed a way to accept any kind of input. It now makes sense why these dropdowns weren't used before, we don't have a method of accepting any old input using our dropdowns. I added a new method for this, you can type anything in that input, press enter and it will use it for the revision input, but it clearly needs improved UX. I think maybe instead if as we type in that input, we dynamically create a new list item it will be clearer.

We probably need a UX issue to improve this but maybe its worth merging this for the sake of the spinach tests?

Mentioned in merge request !6922 (merged)

Added 76 commits:

• cb749fa1...a453dace - 74 commits from branch master
• d78c667d - Fix broken Spinach tests caused by changes in !6550 (merged)
• 93e464f4 - Added logic to handle a revision input that does not exist in the menu

Compare with previous version

Status changed to merged

Mentioned in commit 7d196816

Milestone changed to %8.12

Added ~149423 label

Mentioned in commit 913c1cd8

Mentioned in merge request !6926 (merged)

Mentioned in commit cb8654e8

Mentioned in issue #22011 (closed)