Something went wrong while fetching comments. Please try again.
Fixes labels multi-encode and selecting labels with single quotes
What does this MR do?
Replaced single quotes with escaped single quotes when setting item .is-active
and when removing its field.
Adds a test to test selecting 2 different labels (one with a single quote) with a full page load inbetween, it checks the labels are selected as well as shown as .is-active
in the list.
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
The javascript handles the url encoding when it is sent to the server so we shouldn't let the javascript begin processing an already encoded string but we needed to stop single quotes from breaking a jquery selector.
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
CHANGELOG entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if you do - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #21961 (closed)
Closes #21880 (closed)
Closes #21248 (closed)
Closes #20759 (closed)
Closes #21935 (closed)
Merge request reports
Activity
Please register or sign in to reply